Send JSON over TCP connection

[mandoza]

Hello, I've the following code that i want to have an optimized way to send it over a TCP connection , mainly the JSON converted class .
My question is :

WHAT'S THE BEST WAY TO ADD THIS SERIALIZED CLASS TO

Delphi-Quellcode:

DeptInfo:Array of char;

MAINLY THE OPTIMIZED WAY

Delphi-Quellcode:

type
  TDepartmentsInfo  = Packed Record
    Packet_ID:Integer;
   BuffSize:Integer;
    DeptInfo:Array of char;// This will hold the JSON converted class
  end;
  PDepartmentsInfo = ^TDepartmentsInfo;
  
  
  
  //---
  type  
  TDepartment = class       
  strict private
    FDeptName: string;
   FDeptID:Integer;
  public
    property DeptName: string read FDeptName write FDeptName;
   property DeptID: integer read FDeptID write FDeptID;
  end;

  TDepartmentList = class(TObjectList<TDepartment>);
  ...
  
  Procedure SerializeAndSend();
  var
  DepartmentList: TDepartmentList;
  Department: TDepartment;
  Json: string;
  DepartmentsInfo: TDepartmentsInfo;
begin
  DepartmentList := TDepartmentList.Create();
  try
    Department := TDepartment.Create();
    Department.DeptName := 'Finance';
    Department.DeptID := 10;
    DepartmentList.Add(Department);

    Department := TDepartment.Create();
    Department.DeptName := 'HUMAN RESOURCE';
    Department.DeptID := 11;
    DepartmentList.Add(Department);

    Json := TJson.ObjectToJsonString(DepartmentList);
   // Send this info to OUR Resquest Sender Socket
   DepartmentsInfo.Packet_ID:=1;
   DepartmentsInfo.BuffSize:=Sizeof(TDepartmentsInfo);
   
   {
    WHAT'S THE BEST WAY TO ADD THIS SERIALIZED CLASS TO DeptInfo:Array of char;
    MAINLY THE OPTIMIZED WAY
   }
   
   // NOW SEND
   SocketSendDeptInfo(@DepartmentsInfo, DepartmentsInfo.BuffSize);
   
  finally
    DepartmentList.Free();
  end;

end;

Thank you .

[TiGü]

Do you need a conversion from

Delphi-Quellcode:

string

to

Delphi-Quellcode:

array of char

?

[mandoza]

Zitat:

Zitat von TiGü (Beitrag 1446648)

Do you need a conversion from

Delphi-Quellcode:

string

to

Delphi-Quellcode:

array of char

?

Yes, or any best suggestions to replace

Delphi-Quellcode:

array of char

Thank you

[mjustin]

Cross-post - see https://stackoverflow.com/questions/...tcp-connection

[mandoza]

Zitat:

Zitat von mjustin (Beitrag 1446681)

Cross-post - see https://stackoverflow.com/questions/...tcp-connection

Thank you , But is there any issue in cross-posting my question ?
That was just to have multi and efficient replies ( cause i know there're many Delphi Gurus here and at Sackoverflow ....

Again thank you .

[TiGü]

Please be aware, in this way you serialize the internal structure of the TDepartmentList.

Code:

'{"ownsObjects":true,"listHelper":[2],"items":[{"deptName":"Finance","deptID":10},{"deptName":"HUMAN RESOURCE","deptID":11}]}'

Solution:

Delphi-Quellcode:

program Project1;

{$APPTYPE CONSOLE}
{$R *.res}

uses
    System.SysUtils,
    System.Generics.Collections,
    REST.Json;

type
    TDepartmentsInfo = Packed Record
        Packet_ID: Integer;
        DeptInfo: TArray<Char>; // This will hold the JSON converted class
        function BuffSize: Integer;
    end;

    PDepartmentsInfo = ^TDepartmentsInfo;

type
    TDepartment = class
    strict private
        FDeptName: string;
        FDeptID: Integer;
    public
        property DeptName: string read FDeptName write FDeptName;
        property DeptID: Integer read FDeptID write FDeptID;
    end;

    TDepartmentList = class(TObjectList<TDepartment>);

function TDepartmentsInfo.BuffSize: Integer;
begin
    Result := SizeOf(Packet_ID) + (SizeOf(Char) * Length(DeptInfo));
end;

procedure SocketSendDeptInfo(const DepartmentsInfo: PDepartmentsInfo; BufferSize: Integer);
begin

end;

Procedure SerializeAndSend();
var
    DepartmentList: TDepartmentList;
    Department: TDepartment;
    Json: string;
    DepartmentsInfo: TDepartmentsInfo;
begin
    DepartmentList := TDepartmentList.Create();
    try
        Department := TDepartment.Create();
        Department.DeptName := 'Finance';
        Department.DeptID := 10;
        DepartmentList.Add(Department);

        Department := TDepartment.Create();
        Department.DeptName := 'HUMAN RESOURCE';
        Department.DeptID := 11;
        DepartmentList.Add(Department);

        Json := TJson.ObjectToJsonString(DepartmentList);
        DepartmentsInfo.Packet_ID := 1;

        DepartmentsInfo.DeptInfo := Json.ToCharArray;

        SocketSendDeptInfo(@DepartmentsInfo, DepartmentsInfo.BuffSize);
    finally
        DepartmentList.Free();
    end;

end;

begin
  SerializeAndSend;
end.

[jobo]

Zitat:

Zitat von mandoza (Beitrag 1446702)

Zitat:

Zitat von mjustin (Beitrag 1446681)

Cross-post - see https://stackoverflow.com/questions/...tcp-connection

Thank you , But is there any issue in cross-posting my question ?

LOL, of course, there are several issues in doing so! Beside reading forum rules, is this Your first post and also the first time reading in a forum and You realy didn't get it?

The least You can do:
It is a matter of courtesy and respect to indicate the crosspost right from the start.

[Neutral General]

Zitat:

Zitat von jobo (Beitrag 1446821)

Zitat:

Zitat von mandoza (Beitrag 1446702)

Zitat:

Zitat von mjustin (Beitrag 1446681)

Cross-post - see https://stackoverflow.com/questions/...tcp-connection

Thank you , But is there any issue in cross-posting my question ?

LOL, of course, there are several issues in doing so! Beside reading forum rules, is this Your first post and also the first time reading in a forum and You realy didn't get it?

The least You can do:
It is a matter of courtesy and respect to indicate the crosspost right from the start.

... It's just easier to see for each side what has already been posted (somewhere else).
It's not that big of a tragedy you make it out to be..
Courtesy and respect? Really? :roll:

[mandoza]

So many thanks TiGü , can you please provide the inverse way too ( to read the packet back * Deserialization * ) .

Again so many thanks

[mandoza]

Zitat:

Zitat von jobo (Beitrag 1446821)

Zitat:

Zitat von mandoza (Beitrag 1446702)

Zitat:

Zitat von mjustin (Beitrag 1446681)

Cross-post - see https://stackoverflow.com/questions/...tcp-connection

Thank you , But is there any issue in cross-posting my question ?

LOL, of course, there are several issues in doing so! Beside reading forum rules, is this Your first post and also the first time reading in a forum and You realy didn't get it?

The least You can do:
It is a matter of courtesy and respect to indicate the crosspost right from the start.

OK sorry for that ... really

[mandoza]

Zitat:

Zitat von TiGü (Beitrag 1446795)

Please be aware, in this way you serialize the internal structure of the TDepartmentList.

Code:

'{"ownsObjects":true,"listHelper":[2],"items":[{"deptName":"Finance","deptID":10},{"deptName":"HUMAN RESOURCE","deptID":11}]}'

Is there any issue with that ( network latency ... etc ) ?
Please any other better way .

[Sherlock]

Hi mandoza, I would like to remind you, that we have a fine english speaking sibling to this forum found here: en.delphipraxis.net.

Sherlock

[TiGü]

Zitat:

Zitat von mandoza (Beitrag 1446828)

Is there any issue with that ( network latency ... etc ) ?
Please any other better way .

It's unnessacry overhead and can't properly parsed in other dev environments.
Imagine if someone with Javascript, C++ or something else want to parse your JSON with ownObjects and listHelper.

You can workaround this with a simple data transfer object (DTO).

Code:

'{"items":[{"deptName":"Finance","deptID":10},{"deptName":"HUMAN RESOURCE","deptID":11}]}'

Delphi-Quellcode:

program Project1;

{$APPTYPE CONSOLE}
{$R *.res}

uses
    Department in 'Department.pas',
    System.SysUtils,
    REST.Json;

Procedure SerializeAndSend;
var
    DepartmentList, DepartmentList2: TDepartmentList;
    Department: TDepartment;
    Json: string;
    DepartmentsInfo: TDepartmentsInfo;
    DepartmentStore: TDepartmentStore;
begin
    DepartmentList := TDepartmentList.Create;
    try
        Department := TDepartment.Create;
        Department.DeptName := 'Finance';
        Department.DeptID := 10;
        DepartmentList.Add(Department);

        Department := TDepartment.Create;
        Department.DeptName := 'HUMAN RESOURCE';
        Department.DeptID := 11;
        DepartmentList.Add(Department);

        DepartmentStore := TDepartmentStore.Create(DepartmentList.ToArray);
        try
            Json := TJson.ObjectToJsonString(DepartmentStore);
        finally
            DepartmentStore.Free;
        end;

    finally
        DepartmentList.Free();
    end;

    DepartmentsInfo.Packet_ID := 1;
    DepartmentsInfo.DeptInfo := Json.ToCharArray;
    SocketSendDeptInfo(@DepartmentsInfo, DepartmentsInfo.BuffSize);

    // Deserialization
    DepartmentStore := TJson.JsonToObject<TDepartmentStore>(Json);
    DepartmentList2 := TDepartmentList.Create();
    try
        DepartmentList2.AddRange(DepartmentStore.Items);
    finally
        DepartmentList2.Free;
    end;
end;

begin
    SerializeAndSend;
    Readln;

end.

Delphi-Quellcode:

unit Department;

interface

uses
    System.SysUtils,
    System.Generics.Collections,
    REST.Json,
    System.Rtti;

type
    TDepartmentsInfo = Packed Record
        Packet_ID: Integer;
        DeptInfo: TArray<Char>; // This will hold the JSON converted class
        function BuffSize: Integer;
    end;

    PDepartmentsInfo = ^TDepartmentsInfo;

type
    TDepartment = class
    strict private
        FDeptName: string;
        FDeptID: Integer;
    public
        property DeptName: string read FDeptName write FDeptName;
        property DeptID: Integer read FDeptID write FDeptID;
    end;

    TDepartmentList = class(TObjectList<TDepartment>);

    TDepartmentStore = class
    private
        FItems: TArray<TDepartment>;
    public
        constructor Create(const AItems: TArray<TDepartment>);
        property Items: TArray<TDepartment> read FItems;
    end;

procedure SocketSendDeptInfo(const DepartmentsInfo: PDepartmentsInfo;
  BufferSize: Integer);

implementation

function TDepartmentsInfo.BuffSize: Integer;
begin
    Result := SizeOf(Packet_ID) + (SizeOf(Char) * Length(DeptInfo));
end;

procedure SocketSendDeptInfo(const DepartmentsInfo: PDepartmentsInfo;
  BufferSize: Integer);
begin

end;

constructor TDepartmentStore.Create(const AItems: TArray<TDepartment>);
begin
    FItems := AItems;
end;

end.

[Schokohase]

Talking about overhead ... why not remove all overhead?

Code:

[
  {
    "deptName": "Finance",
    "deptID": 10
  },
  {
    "deptName": "HUMAN RESOURCE",
    "deptID": 11
  }
]

contains the same information as

Code:

{
  "items": [
    {
      "deptName": "Finance",
      "deptID": 10
    },
    {
      "deptName": "HUMAN RESOURCE",
      "deptID": 11
    }
  ]
}

but with less chars (overhead).

[jobo]

Zitat:

Zitat von Neutral General (Beitrag 1446824)

Courtesy and respect? Really? :roll:

In my point of view, posting questions and asking for help should include these points.
Asking sames question in different communities without letting each other know, forces people to waste their power and time. That's disrespectful in my point of view.

Although he apologized and seems to understand the problem, he didn't link to this post on SO.

And pretending that's all new .. doesn't make it any better.