Change one value + many OnChange events = stack overflow

[Sir Rufo]

1. EnableAutoChange/DisableAutoChange
   IMHO it would be better to use a Flag to dis-/enable the execution of the Event-Code
   
   Delphi-Quellcode:

   procedure TMainForm.RGBChange(Sender: TObject);
   begin
     if not EnabledUpdateFlag then
       Exit;
     UpdateColor(Sender, RGBChange, SetRGBValues(edtR.AsInteger, edtG.AsInteger, edtB.AsInteger));
   end;
   
   procedure TMainForm.UpdateColor(Sender: TObject; Event: TNotifyEvent; const AColor: TColor);
   var
     R, G, B: Byte;
     H, S, L: Int32;
     C, M, Y, K: Byte;
     CIEL, CIEa, CIEb: Double;
   begin
     EnabledUpdateFlag := False;
     try
   
       ...
   
     finally
       EnableUpdateFlag := True;
     end;
   end;

   or like this
   
   Delphi-Quellcode:

   procedure TMainForm.UpdateColor(Sender: TObject; Event: TNotifyEvent; const AColor: TColor);
   var
     R, G, B: Byte;
     H, S, L: Int32;
     C, M, Y, K: Byte;
     CIEL, CIEa, CIEb: Double;
   begin
     if not EnabledUpdateFlag then
       Exit;
   
     EnabledUpdateFlag := False;
     try
   
       ...
   
     finally
       EnableUpdateFlag := True;
     end;
   end;

   Now u don't have to set/reset all the Event-Properties (and u can't miss one of them)
   
   
2. Useless Method-Parameters
   What are the parameters used for ... seems to me useless
   
   Delphi-Quellcode:

   procedure TMainForm.DisableAutoChange(Sender: TObject; Event: TNotifyEvent);
   begin // Sender and Event are never used in this Method, so they are useless!
     HSLPicker.OnChange := nil;
   
     SLPicker.OnChange := nil;
     HuePicker.OnChange := nil;
   
     HSVPicker.OnChange := nil;
     LightnessPicker.OnChange := nil;
   
     edtR.OnChange := nil;
     edtG.OnChange := nil;
     edtB.OnChange := nil;
   
     edtH.OnChange := nil;
     edtS.OnChange := nil;
     edtL.OnChange := nil;
   
     edtM.OnChange := nil;
     edtM.OnChange := nil;
     edtY.OnChange := nil;
     edtK.OnChange := nil;
   
     edtCIEL.OnChange := nil;
     edtCIEa.OnChange := nil;
     edtCIEb.OnChange := nil;
   end;

[WojTec]

I tried with variable too, so why don't worked for me Now working Just one question, values in edits are updated when I moving mouse on picker, but color in box is not updated in same time as these edits. Why?

[Sir Rufo]

Did u check with the Debugger?

Step trough ur code with the Debugger and u will find the "missing link"

[WojTec]

I know - it's bug in THSLColorPicker component, calling a few times DoChange procedure - 3 times instead 1 in spectrum box and 1 or 2 in brightness trackbar! God!

I'll try detect with calls are not needed.

[WojTec]

In HSLColorPicker.pas look for HSPickerChange(). Then change to:

Delphi-Quellcode:

procedure THSLColorPicker.HSPickerChange(Sender: TObject);
begin
 FLPicker.Hue := FHSPicker.HueValue;
// FLPicker.Saturation := FHSPicker.SaturationValue;
// DoChange;
end;

(lines 2 and 3 in this method is not needed any more, because creates problem I told in previous post).