Simple asm from x86 to x64

[WojTec]

Could you make for me compatible with both 32/64 bits this asm code (now is x86 only), because I'm not familiar with Assembler

Delphi-Quellcode:

procedure ByteToHex(const AValue: Byte; Buffer: PAnsiChar);
asm
  JMP @@Convert
  @@HexTable:
    DB '0123456789ABCDEF';
  @@Convert:
    PUSH ECX  // Invalid combination of opcode and operands
    XOR ECX, ECX
    MOV CL, AL
    SHR CL, 4
    MOV CL, @@HexTable.Byte[ECX]  // Assembler instruction requires a 32bit absolute address fixup which is invalid for 64bit
    MOV BYTE PTR [EDX], CL
    MOV CL, AL
    AND CL, 0Fh
    MOV CL, @@HexTable.Byte[ECX]  // Above error also here
    MOV BYTE PTR [EDX+1], CL
    POP ECX
end;

[Fritzew]

warum Assembler?
hast Du nicht genug mit Delphi und C++ zu tun


sysutils : IntToHex

[jbg]

You could try this code. It is even slightly faster than your assembler code if you activate the compiler's code optimization.

Delphi-Quellcode:

procedure ByteToHex(const AValue: Byte; Buffer: PAnsiChar);
const
  HexChars: array[0..15] of AnsiChar = '0123456789ABCDEF';
begin
  Buffer[0] := HexChars[AValue shr 4];
  Buffer[1] := HexChars[AValue and $F];
end;

[WojTec]

This is very old procedure I found in past, it was faster than build-in routines, but if now Delphi can do it better the choice is simple, thanks buddies

[Fritzew]

Du weist aber das du in einem deutschen Forum bist, oder?

[sh17]

Zitat von Fritzew:

Du weist aber das du in einem deutschen Forum bist, oder?

In einem der besten Delphi-Foren überhaupt, denke ich. Da darf auch mal englisch geschrieben werden.