Neuer FixInsight ist da!

[Roman Yankovsky]

It supports all Delphi versions from Delphi 2006 to XE7.

[Roman Yankovsky]

... to XE8 :)

[Der schöne Günther]

Please have a look at
http://www.delphipraxis.net/1303391-post1.html

Is it possible for FixInsight to raise a W1037? Dcc32 and Dcc64 fail to do so.

[Roman Yankovsky]

Nice idea, thanks.
I will think about implementing this.

[Der schöne Günther]

Just noticed: You raise a W523 "Interface declared without a GUID" for generic interfaces. Generic interfaces cannot have a GUID.

And by the way: I believe a W504 (Missing INHERITED call in constructor/destructor) is not appropriate for a record constructor since they don't support inheritance in the first place.

[Stevie]

Zitat:

Zitat von Der schöne Günther (Beitrag 1307429)

Generic interfaces cannot have a GUID.

They can - their use is just limited because all instantiations have the same GUID - which can be dangerous but also useful when you know what you are doing.
However Roman might want to disable triggering that warning for generic interfaces.

[Whookie]

Nice idea, gave it a short try and here are my first expiriences:

W522 does enforce "override" to be written in lower case (which is not required)
W521 gives an error with:

Delphi-Quellcode:

function test: boolean;
var
  LResult: Boolean;
begin
  try
    LResult := TRUE;
  finally
    Result := LResult;
  end;
end;

W504 does warn on missing inherited in a constructor directly derived from TObject (even though it might be good practice(?)) I never call them in that circumstance.

[Der schöne Günther]

Zitat:

Zitat von Whookie (Beitrag 1307457)

even though it might be good practice(?) I never call them in that circumstance.

I always explicitly derive from

Delphi-Quellcode:

TObject

and call the (empty) inherited constructor. Java, for example, is different: It implicitly calls the inherited parameterless constructor (if there's any). Otherwise, it's a compile time error.

Another reason is that it often happened to me that I omitted the (then redundant) call to the super constructor but later decided to derive the class from something other than

Delphi-Quellcode:

TObject

. Then, it's easy to miss adding the call to the inherited constructor back in. (FixInsight to the rescue! 8-))

[Whookie]

Zitat:

Zitat von Der schöne Günther (Beitrag 1307459)

...but later decided to derive the class from something other than

Delphi-Quellcode:

TObject

. Then, it's easy to miss adding the call to the inherited constructor back in. (FixInsight to the rescue! 8-))

That's one hell of an argument...

[Der schöne Günther]

Zitat:

Zitat von Der schöne Günther (Beitrag 1307429)

And by the way: I believe a W504 (Missing INHERITED call in constructor/destructor) is not appropriate for a record constructor since they don't support inheritance in the first place.

Also, whether class helpers should be checked for a missing "inherited" call in the constructor is also debatable. An "inherited" statement in a class helper constructor is illegal.